Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use 'in' operator to search for '0' in arguments_marker #16781

Closed
SheetJSDev opened this issue Nov 5, 2017 · 4 comments
Closed

Cannot use 'in' operator to search for '0' in arguments_marker #16781

SheetJSDev opened this issue Nov 5, 2017 · 4 comments
Labels
wrong repo Issues that should be opened in another repository.

Comments

@SheetJSDev
Copy link
Contributor

  • Version: 9.0.0
  • Platform: darwin and linux

Error as stated in message.

To elicit the error, clone https://github.com/sheetjs/js-xlsx and npm install:

$ cd /tmp
$ git clone https://github.com/sheetjs/js-xlsx
$ cd js-xlsx
$ npm install -g [email protected]
$ npm install

Relevant cut from the debug log:

1386 silly addNamed [email protected]
1387 verbose addNamed "0.1.3" is a plain semver version for right-align
1388 verbose get https://registry.npmjs.org/wordwrap not expired, no request
1389 silly cache afterAdd [email protected]
1390 verbose afterAdd /Users/sheetjs/.npm/right-align/0.1.3/package/package.json not in flight; writing
1391 verbose correctMkdir /Users/sheetjs/.npm correctMkdir not in flight; initializing
1392 silly cache afterAdd [email protected]
1393 verbose afterAdd /Users/sheetjs/.npm/wordwrap/0.0.2/package/package.json not in flight; writing
1394 verbose correctMkdir /Users/sheetjs/.npm correctMkdir not in flight; initializing
1395 verbose afterAdd /Users/sheetjs/.npm/wordwrap/0.0.2/package/package.json written
1396 verbose afterAdd /Users/sheetjs/.npm/right-align/0.1.3/package/package.json written
1397 verbose stack TypeError: Cannot use 'in' operator to search for '0' in arguments_marker
1397 verbose stack     at forEach (<anonymous>)
1397 verbose stack     at Entry._setProps (/usr/local/lib/node_modules/npm/node_modules/tar/lib/entry.js:165:25)
1397 verbose stack     at new Entry (/usr/local/lib/node_modules/npm/node_modules/tar/lib/entry.js:46:8)
1397 verbose stack     at Parse._startEntry (/usr/local/lib/node_modules/npm/node_modules/tar/lib/parse.js:241:11)
1397 verbose stack     at Parse._process (/usr/local/lib/node_modules/npm/node_modules/tar/lib/parse.js:131:12)
1397 verbose stack     at BlockStream.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/tar/lib/parse.js:47:8)
1397 verbose stack     at emitOne (events.js:125:13)
1397 verbose stack     at BlockStream.emit (events.js:221:7)
1397 verbose stack     at BlockStream._emitChunk (/usr/local/lib/node_modules/npm/node_modules/tar/node_modules/block-stream/block-stream.js:145:10)
1397 verbose stack     at BlockStream.write (/usr/local/lib/node_modules/npm/node_modules/tar/node_modules/block-stream/block-stream.js:45:10)

This is not triggered by any previous node version (tested against latest 8.x 7.x 6.x 5.x 4.x 0.12.x 0.10.x 0.8.x).

A quick search suggests this is possibly a v8 issue: https://bugs.chromium.org/p/chromium/issues/detail?id=777836

@mscdex
Copy link
Contributor

mscdex commented Nov 5, 2017

General help questions should be posted to the nodejs/help issue tracker instead. This issue tracker is for reporting bugs and submitting feature requests for node core. Issues with npm or other tools that use node should be posted to the appropriate issue tracker for those tools, unless it can be proven that the issue is in fact with node core and not the tool in question.

@mscdex mscdex closed this as completed Nov 5, 2017
@mscdex mscdex added the wrong repo Issues that should be opened in another repository. label Nov 5, 2017
@SheetJSDev
Copy link
Contributor Author

If you read the proposed fix in the linked issue from chromium:

https://bugs.chromium.org/p/chromium/issues/detail?id=777836#c6

https://chromium-review.googlesource.com/c/v8/v8/+/738176

Disable --turbo-inline-array-builtins by default.

Current chrome stable has a high number of crashes due to bugs in
this feature. These bugs are already fixed but the fixes are hard
to merge back. Therefore we decided to disable the feature in stable.
This CL is intended to be merged to stable and then reverted in tot.

The comment certainly suggests this is something related to V8. The issue itself happens to manifest in npm usage, but the actual problem is within the domain of node core.

@mscdex
Copy link
Contributor

mscdex commented Nov 5, 2017

See: #16704

@DanielRuf
Copy link

Is this also in Node.js 9 and in which versions?

squaremo added a commit to amqp-node/amqplib that referenced this issue Jul 2, 2018
Uglify 2.4 has a vulnerability that doesn't affect users of this
library, but does result in build warnings:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-8858

Early minor versions of NodeJS 9.x inherited a bug from V8 that led to
repeated test failures: nodejs/node#16781.
squaremo added a commit to amqp-node/amqplib that referenced this issue Jul 9, 2018
Uglify 2.4 has a vulnerability that doesn't affect users of this
library, but does result in build warnings:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-8858

Early minor versions of NodeJS 9.x inherited a bug from V8 that led to
repeated test failures: nodejs/node#16781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrong repo Issues that should be opened in another repository.
Projects
None yet
Development

No branches or pull requests

3 participants