-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-v8.0.0 make test failure #13344
Comments
cc @nodejs/n-api We should skip this test if the V8 test file is not present, I guess. |
This is when you download the source from |
node.js download was from https://nodejs.org/dist/v8.0.0/node-v8.0.0.tar.gz |
It appears that the deps/v8/test directory is missing from the archive. And this is why its throwing errors for missing files. Cloning it from the repo could fix the issue. |
The N-API test testInstanceOf.js relies on several V8 test files which may not exist in downloadable archives. If the files are missing, this commit causes a warning to be emitted rather than failing the test. Refs: nodejs#14113 Fixes: nodejs#13344 PR-URL: nodejs#14123 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
The N-API test testInstanceOf.js relies on several V8 test files which may not exist in downloadable archives. If the files are missing, this commit causes a warning to be emitted rather than failing the test. Refs: #14113 Fixes: #13344 PR-URL: #14123 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
The N-API test testInstanceOf.js relies on several V8 test files which may not exist in downloadable archives. If the files are missing, this commit causes a warning to be emitted rather than failing the test. Refs: #14113 Fixes: #13344 PR-URL: #14123 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
The N-API test testInstanceOf.js relies on several V8 test files which may not exist in downloadable archives. If the files are missing, this commit causes a warning to be emitted rather than failing the test. Refs: nodejs#14113 Fixes: nodejs#13344 PR-URL: nodejs#14123 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
The N-API test testInstanceOf.js relies on several V8 test files which may not exist in downloadable archives. If the files are missing, this commit causes a warning to be emitted rather than failing the test. Refs: #14113 Fixes: #13344 Backport-PR-URL: #19447 PR-URL: #14123 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Version: $ ./node -v
v8.0.0
Platform: $ uname -a
Linux vm-001 3.16.0-4-686-pae deps: update openssl to 1.0.1j #1 SMP Debian 3.16.43-2 (2017-04-30) i686 GNU/Linux
Subsystem: build system, make test
$ make test
make -C out BUILDTYPE=Release V=1
... 564 lines later...
[----------] Global test environment tear-down
[==========] 46 tests from 6 test cases ran. (113 ms total)
[ PASSED ] 46 tests.
/usr/bin/python tools/test.py --mode=release -J
doctool inspector known_issues message pseudo-tty parallel sequential
async-hooks addons addons-napi
=== release test ===
Path: addons-napi/test_instanceof/test
fs.js:638
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^
Error: ENOENT: no such file or directory, open '/usr/src/node-v8.0.0/deps/v8/test/mjsunit/instanceof.js'
at Object.fs.openSync (fs.js:638:18)
at Object.fs.readFileSync (fs.js:540:33)
at testFile (/usr/src/node-v8.0.0/test/addons-napi/test_instanceof/test.js:37:23)
at Object. (/usr/src/node-v8.0.0/test/addons-napi/test_instanceof/test.js:42:1)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
at Function.Module.runMain (module.js:605:10)
Command: out/Release/node --napi-modules /usr/src/node-v8.0.0/test/addons-napi/test_instanceof/test.js
[03:55|% 100|+ 1568|- 1]: Done
Makefile:196: recipe for target 'test' failed
make: *** [test] Error 1
The text was updated successfully, but these errors were encountered: