Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel/test-process-setuid-setgid fails if "nobody" user does not exist #13071

Closed
Qantas94Heavy opened this issue May 17, 2017 · 3 comments
Closed

parallel/test-process-setuid-setgid fails if "nobody" user does not exist #13071

Qantas94Heavy opened this issue May 17, 2017 · 3 comments
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Comments

@Qantas94Heavy
Copy link
Contributor

  • Version: 7.10.0
  • Platform: Linux
  • Subsystem: test

Some isolated build or test VMs don't have a "nobody" user, causing the parallel/test-process-setuid-setgid test to fail.
@mscdex mscdex added process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. labels May 17, 2017
@gibfahn
Copy link
Member

gibfahn commented May 17, 2017

Test was re-enabled in #12403, so cc/ @Trott

@Trott
Copy link
Member

Trott commented May 19, 2017 •
edited
Loading

@Qantas94Heavy Are you running tests as superuser or as an unprivileged user? Can you copy/paste the test failure output?

Trott added a commit to Trott/io.js that referenced this issue May 19, 2017
@Trott
test: allow for absent nobody user in setuid test
73b55a8 
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

Fixes: nodejs#13071
@Trott Trott mentioned this issue May 19, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented May 19, 2017

Fix (for the non-super user situation only) in #13112. @Qantas94Heavy If you could test it, that would be great. Thanks.

@Trott Trott closed this as completed in 8e47600 May 22, 2017
jasnell pushed a commit that referenced this issue May 23, 2017
@Trott @jasnell
test: allow for absent nobody user in setuid test
f0fcac6 
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: #13112
Fixes: #13071
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this issue May 23, 2017
@Trott @jasnell
test: allow for absent nobody user in setuid test
1af8b70 
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: #13112
Fixes: #13071
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this issue Jul 17, 2017
@Trott @MylesBorins
test: allow for absent nobody user in setuid test
92cc96f 
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: #13112
Fixes: #13071
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: allow for absent nobody user in setuid test Trott/io.js
4 participants
@mscdex @Trott @Qantas94Heavy @gibfahn