readdir docs don’t mention when options argument was added #12299
Comments
vsemozhetbyt
added
doc
joyeecheung
added
the
good first issue
|
The per-item changes in the documentation is added in #11489, which happened much later than the v6.0.0 release, so it's very likely there would be something falling through the cracks. The differences between v4 and v6 are also documented in I agree the missing documentation for previous changes would confuse users, and it definitely needs improvement, though I believe the documentation would be more reliable in future releases, now that we have a system like this in place. Labeled as a good first contribution, feel free to open a PR to fix this! (Also, maybe we can open a meta issue to hunt for more missing changelog items? Should not be that hard if we go through the semver-major PRs) |
We'd have to look at semver-minor PRs as well (and check whether/how far they got backported). |
|
I'll take this up! |
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
optionswas added in Node 6.0.0 by #5616. But it’s not mentioned, which led me to writing generic code that passed throughundefinedforoptions, which naturally made it fall apart on the Node 4 LTS release that doesn’t supportoptionsand so perceived it as just an undefined callback.This really worries me. If something like this can change without any note in the history, what else is lacking history of changes that will come and bite me later? I no longer trust this documentation. At least https://nodejs.org/docs/latest-v4.x/api/fs.html#fs_fs_readdir_path_callback is still there, I’ll just need to remember to work there.
The text was updated successfully, but these errors were encountered: