Using core.whitespace fix in git #11412
Comments
mscdex
added
the
meta
|
I think you can also set these per-repo. Is it possible that I do think it is worthwhile to still suggest people enable the whitespace fixer globally. Not sure about altering |
|
@Fishrock123 what I'm saying is I don't think I'm pretty sure this stuff has to go in |
|
Let's drop that recommendation, we already recommend https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#technical-howto |
|
Regarding |
|
I can confirm that option |
|
PR #12445 removes this misleading instruction |
|
I think I'd rather just correct the option name rather than remove it. The less explicit parameters needed the better IMHO. |
According to docs it is used only on applying patch. Is it useful/intended result of this instruction? |
Use apply.whitespace=fix rather than core.whitespace=fix Ref: #11412 PR-URL: #12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use apply.whitespace=fix rather than core.whitespace=fix Ref: #11412 PR-URL: #12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
#12445 landed, I think this can be closed now. Feel free to re-open if I’m wrong. |
Use apply.whitespace=fix rather than core.whitespace=fix Ref: #11412 PR-URL: #12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use apply.whitespace=fix rather than core.whitespace=fix Ref: #11412 PR-URL: #12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use apply.whitespace=fix rather than core.whitespace=fix Ref: #11412 PR-URL: #12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use apply.whitespace=fix rather than core.whitespace=fix Ref: #11412 PR-URL: #12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use apply.whitespace=fix rather than core.whitespace=fix Ref: nodejs/node#11412 PR-URL: nodejs/node#12445 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
We recommend using
git config --global --add core.whitespace fixin doc/onboarding.md, but I can't find any mention of that setting in the git docs. There is acore.whitespace, but it doesn't seem to have a fix option. However,apply.whitespacedoes, see the apply docs.I think what we need is
git config --global --add apply.whitespace fix. Note that this only fixes whitespace when you apply a patch. Rebase has a whitespace option as well, but it's apparently incompatible with--interactive, so I'm not sure if we should use it.We might also consider suggesting
git config --global diff.wsErrorHighlight all, which makesgit diffandgit showhighlight whitespace errors (see docs).cc/ @Fishrock123 (from git blame)
The text was updated successfully, but these errors were encountered: