Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector Record Allocation Timeline bugged #11401

Closed
Somebi opened this issue Feb 15, 2017 · 14 comments · Fixed by #14346
Closed

inspector Record Allocation Timeline bugged #11401

Somebi opened this issue Feb 15, 2017 · 14 comments · Fixed by #14346
Assignees
@eugeneo
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@Somebi
Copy link

Somebi commented Feb 15, 2017 •
edited
Loading

Ubuntu 16.04
Node.js v7.4.0
tried first on Google Chrome Version 54~
then on latest beta Google Chrome Version 57.0.2987.37 beta (64-bit)

node --trace_gc --max_old_space_size=5000 --inspect /var/local/bot/gather_all.js

chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=127.0.0.1:9229/8743459a-0079-47f3-a8c0-2493fd56c3ca

bug_or_feature

Is that a chrome dev tools bug or bug is somewhere inside node.js or even inside v8, not sure...

But the results should be like this:
bug_or_feature2

Timeline doesn't have anything inside it...

Maybe i'm doing something wrong?
@bnoordhuis bnoordhuis added the inspector Issues and PRs related to the V8 inspector protocol label Feb 15, 2017
@Somebi
Copy link
Author

Somebi commented Feb 15, 2017 •
edited
Loading

Added versions in initial post, will try with some of the latest nodes, maybe with master branch too. Will try to compile from sources.

@algv
Copy link

algv commented Feb 15, 2017 •
edited
Loading

--max_old_space_size=5000

It not work correctly. See #10185 Fixes in #10186 node v7.5.0

@Somebi
Copy link
Author

Somebi commented Feb 15, 2017

I have tried this in v7.5.0 still doesn't work. Will try without --max_old_space_size argument.

@bnoordhuis bnoordhuis mentioned this issue Feb 15, 2017
Merged
@jmcbee
Copy link

jmcbee commented Feb 16, 2017

I'm experiencing this as well. The timeline is just empty but it has a summary. Node v7.5.0

@jmcbee
Copy link

jmcbee commented Feb 16, 2017

If it helps

  1. I run the script with node --inspect --debug-brk
  2. Start Record Allocation Timeline
  3. Go to Sources and resume execution
  4. When it is done, I go back to Profiles and stop recording.

@jazoom
Copy link

jazoom commented Apr 1, 2017 •
edited
Loading

Still doesn't work in Node v7.8.0

It may be an issue in Chrome. I just tried with Node v6.10.1 and it didn't work.

@Somebi
Copy link
Author

Somebi commented Apr 1, 2017

Too bad, this was a great feature. Well it's still experimental feature as i understand. Hope it will reach stable release.

@anlauren
Copy link

Same problem here.
Note that the other profile recorders work fine

@silenceisgolden
Copy link

Is there any movement on this? v8.1.3 still does not have the timeline working properly.

@gibfahn
Copy link
Member

gibfahn commented Jul 12, 2017

I guess cc/ @nodejs/v8-inspector

@eugeneo
Copy link
Contributor

eugeneo commented Jul 17, 2017

Please open a bug against Chrome DevTools. Node provides the profiling data (as you can see from a table beneath the chart).

@eugeneo eugeneo closed this as completed Jul 17, 2017
@eugeneo
Copy link
Contributor

eugeneo commented Jul 17, 2017

Nope, I was wrong - there are issues both on the DevTools and on the Node sides. I am reopening this.

@eugeneo eugeneo reopened this Jul 17, 2017
@eugeneo eugeneo self-assigned this Jul 17, 2017
@eugeneo
Copy link
Contributor

eugeneo commented Jul 18, 2017

This is an issue tracking non-Node bug: https://bugs.chromium.org/p/chromium/issues/detail?id=745023

@silenceisgolden
Copy link

Thanks for the update @eugeneo!

@eugeneo eugeneo mentioned this issue Jul 18, 2017
Merged
2 tasks
addaleax pushed a commit that referenced this issue Jul 27, 2017
@addaleax
inspector: implement V8Inspector timer
71cb1cd 
This timer is currently only used by a profiler. Note that the timer
invocation will not interrupt JavaScript code.

Fixes: #11401
PR-URL: #14346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugeneo eugeneo

Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

inspector: implement V8Inspector timer
9 participants
@bnoordhuis @eugeneo @Somebi @silenceisgolden @anlauren @jazoom @jmcbee @gibfahn @algv