Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are custom http verbs supported by io.js yet? #1081

Closed
unbornchikken opened this issue Mar 6, 2015 · 10 comments
Closed

Are custom http verbs supported by io.js yet? #1081

unbornchikken opened this issue Mar 6, 2015 · 10 comments
Labels
feature request Issues that request new features to be added to Node.js. http Issues or PRs related to the http subsystem. stalled Issues and PRs that are stalled.

Comments

@unbornchikken
Copy link

According to this issue: nodejs/node-v0.x-archive#3192

Because I'm having this: http://stackoverflow.com/questions/28899036/node-js-cannot-do-profind-with-request-module

In a nushell I cannot do a PROPFIND request in node/io.js.

@unbornchikken unbornchikken changed the title Is custom http verbs supported by io.js yet? Are custom http verbs supported by io.js yet? Mar 6, 2015
@Fishrock123 Fishrock123 added the http Issues or PRs related to the http subsystem. label Mar 6, 2015
@jasnell
Copy link
Member

jasnell commented Mar 6, 2015

Thus far, unless I missed it, I do not believe so. It's on my todo list to circle back on this but haven't had the opportunity (to be clear, I want to incorporate this into httpparser so that it'll be supported by both node and io.js)

@Fishrock123
Copy link
Contributor

Requires a version of nodejs/http-parser#158 according to that issue. Not sure if a new patch ever landed.

@jasnell
Copy link
Member

jasnell commented Mar 6, 2015

Don't believe it did. I've since removed that particular branch because I fell out of date rather quickly. An updated fix would be quite similar tho. It's not too difficult to do just haven't had the opportunity to actually work on it.

@mscdex
Copy link
Contributor

mscdex commented Mar 6, 2015

Duplicated my SO answer here:

PROPFIND or any other verb is supported just fine for outbound requests in node and iojs. There is either something else wrong with your request (wrong/bad headers or payload for example) or configuration on the server.

Example of PROPFIND working:

// client.js
require('http').request({
  host: '127.0.0.1',
  port: 8000,
  method: 'PROPFIND'
}, function(res) {
  res.resume();
}).end();

// server.js
require('http').createServer(function(req,res) {
  // echoes "PROPFIND" to stdout
  console.log(req.method);

  res.writeHead(200, { 'Connection': 'close' });
  res.end();
}).listen(8000);

@mscdex
Copy link
Contributor

mscdex commented Mar 6, 2015

By the way, PROPFIND (and the other custom WebDAV methods) is supported by the HTTP parser at least since node v0.8. Outbound requests are not limited to a particular set of HTTP verbs.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 6, 2015

Verified that this works in io.js.

@cjihrig cjihrig closed this as completed Mar 6, 2015
@darky
Copy link
Contributor

darky commented May 26, 2015

Custom HTTP verbs not working on iojs 2.1.0
Custom HTTP verb means any string what I want

@jasnell
Copy link
Member

jasnell commented May 26, 2015

Not yet. Once the new pure js http impl lands they should be, but for now,
the http-parser based impl supports only a fixed set of http verbs.
On May 26, 2015 7:03 AM, "Vladislav Botvin" [email protected]
wrote:

Custom HTTP verbs not working on iojs 2.1.0
Custom HTTP verb means any string what I want


Reply to this email directly or view it on GitHub
#1081 (comment).

@darky
Copy link
Contributor

darky commented May 26, 2015

So need reopen and close, when will released version of iojs with new pure js http

@Fishrock123 Fishrock123 reopened this May 26, 2015
@brendanashworth brendanashworth added the feature request Issues that request new features to be added to Node.js. label Jun 12, 2015
@Trott Trott added the stalled Issues and PRs that are stalled. label Mar 11, 2016
@jasnell
Copy link
Member

jasnell commented Mar 24, 2017

Closing. This is unlikely to happen at all with the http/1 implementation. The http/2 implementation will support any http verbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. http Issues or PRs related to the http subsystem. stalled Issues and PRs that are stalled.
Projects
None yet
Development

No branches or pull requests

8 participants