Skip to content

Commit

Permalink
deps: cherry-pick 7c982e7 from V8 upstream
Browse files Browse the repository at this point in the history
Original commit message:

    PPC/s390: [Turbofan]: Use new MachineTypes in access-builder.

    Port 56429fc14671a10749190a4dfeacd38b7270f6f5

    Original Commit Message:

        Introduced MachineType::TaggedSigned() and TaggedPointer().

        The idea is to quit using the representational dimension of Type, and
        instead encode this information in the MachineRepresentation (itself
        lightly wrapped in MachineType, along with MachineSemantic).

        There are three parts to the whole change:

        1) Places that set the machine representation - constant nodes, loads nad
           stores, global object and native context specialization.

        2) Places that propagate type/representation - this is representation
           inference (aka simplified lowering). At the end of this process we
           expect to have a MachineRepresentation for every node. An interesting
           part of this is phi merging.

        3) Places that examine representation - WriteBarrier elimination does this.
           Currently it's looking at the Type representation dimension, but as
           a part of this change (or in a soon-to-follow change) it can simply
           examine the MachineRepresentation.

    [email protected], [email protected], [email protected], [email protected]
    BUG=
    LOG=N

    Review-Url: https://codereview.chromium.org/2662223003
    Cr-Commit-Position: refs/heads/master@{#42817}

PR-URL: #11263
Backport-of: v8/v8@7c982e7
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
  • Loading branch information
Jaideep Bajwa authored and italoacasas committed Feb 16, 2017
1 parent f542c59 commit fe99edd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 5
#define V8_MINOR_VERSION 5
#define V8_BUILD_NUMBER 372
#define V8_PATCH_LEVEL 40
#define V8_PATCH_LEVEL 41

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/compiler/ppc/instruction-selector-ppc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ void InstructionSelector::VisitStore(Node* node) {
MachineRepresentation rep = store_rep.representation();

if (write_barrier_kind != kNoWriteBarrier) {
DCHECK_EQ(MachineRepresentation::kTagged, rep);
DCHECK(CanBeTaggedPointer(rep));
AddressingMode addressing_mode;
InstructionOperand inputs[3];
size_t input_count = 0;
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/compiler/s390/instruction-selector-s390.cc
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ void InstructionSelector::VisitStore(Node* node) {
MachineRepresentation rep = store_rep.representation();

if (write_barrier_kind != kNoWriteBarrier) {
DCHECK_EQ(MachineRepresentation::kTagged, rep);
DCHECK(CanBeTaggedPointer(rep));
AddressingMode addressing_mode;
InstructionOperand inputs[3];
size_t input_count = 0;
Expand Down

0 comments on commit fe99edd

Please sign in to comment.