CR

nodejs · Jun 4, 2024 · fb82a11 · fb82a11
1 parent 8bc57f9
commit fb82a11
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/lib/internal/test_runner/coverage.js b/lib/internal/test_runner/coverage.js
@@ -15,7 +15,6 @@ const {
   SafeSet,
   StringPrototypeIncludes,
   StringPrototypeLocaleCompare,
-  StringPrototypeRepeat,
   StringPrototypeStartsWith,
 } = primordials;
 const {
@@ -37,14 +36,14 @@ const kLineSplitRegex = /(?<=\r?\n)/u;
 const kStatusRegex = /\/\* node:coverage (?<status>enable|disable) \*\//;
 
 class CoverageLine {
-  constructor(line, src, startOffset) {
-    const newlineLength =
+  constructor(line, startOffset, src, length = src?.length) {
+    const newlineLength = src == null ? 0 :
       RegExpPrototypeExec(kLineEndingRegex, src)?.[0].length ?? 0;
 
     this.line = line;
     this.src = src;
     this.startOffset = startOffset;
-    this.endOffset = startOffset + src.length - newlineLength;
+    this.endOffset = startOffset + length - newlineLength;
     this.ignore = false;
     this.count = this.startOffset === this.endOffset ? 1 : 0;
   }
@@ -84,7 +83,7 @@ class TestCoverage {
 
     const lines = ArrayPrototypeMap(linesWithBreaks, (line, i) => {
       const startOffset = offset;
-      const coverageLine = new CoverageLine(i + 1, line, startOffset);
+      const coverageLine = new CoverageLine(i + 1, startOffset, line);
 
       offset += line.length;
 
@@ -339,8 +338,7 @@ class TestCoverage {
       const { data, lineLengths } = sourceMapCache[url];
       let offset = 0;
       const executedLines = ArrayPrototypeMap(lineLengths, (length, i) => {
-        const startOffset = offset;
-        const coverageLine = new CoverageLine(i + 1, StringPrototypeRepeat('.', length), startOffset);
+        const coverageLine = new CoverageLine(i + 1, offset, null, length);
         offset += length;
         return coverageLine;
       });

diff --git a/test/fixtures/test-runner/coverage-loader/hooks.mjs b/test/fixtures/test-runner/coverage-loader/hooks.mjs
@@ -1,5 +1,5 @@
 const sources = {
-// Virtual file. dosent exist on disk
+// Virtual file. Dosen't exist on disk
   "virtual.js": `
   import { test } from 'node:test';
   test('test', async () => {});

diff --git a/test/fixtures/test-runner/coverage-loader/sum.test.ts b/test/fixtures/test-runner/coverage-loader/sum.test.ts
@@ -4,7 +4,7 @@ import { sum } from './sum'
 
 describe('sum', () => {
   it('should sum two numbers', () => {
-      assert.deepStrictEqual(sum(1,2), 3)
+    assert.deepStrictEqual(sum(1, 2), 3)
   })
 
   it('should error out if one is not a number', () => {