-
Notifications
You must be signed in to change notification settings - Fork 30.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: check version strings have expected pattern
Many were checked, but a few were not.
- Loading branch information
1 parent
482b56a
commit f4225f0
Showing
1 changed file
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4225f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-github This is missing metadata. Fix and force push with
--force-with-lease
?f4225f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this pushed to Node.js core master by accident? Should we force push it out entirely?
f4225f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I force-pushed it out. (If it was supposed to be in Node.js core repo, you can re-land it with metadata.)
f4225f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
git node land
to land it, which I expected to fill in the metadata. In retrospect, I am guessing this is because I selected "no" to the question "do you want to amend your commit"? I didn't have any intention of rewriting the commit message, it was good enough, so I said "no". Lesson learned, I'll reland./cc @joyeecheung