dns: cleanup validation

The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Sep 16, 2021 · eb44d19 · eb44d19
1 parent de10ab2
commit eb44d19
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/internal/dns/utils.js b/lib/internal/dns/utils.js
@@ -32,7 +32,6 @@ const IPv6RE = /^\[([^[\]]*)\]/;
 const addrSplitRE = /(^.+?)(?::(\d+))?$/;
 const {
   ERR_DNS_SET_SERVERS_FAILED,
-  ERR_INVALID_ARG_TYPE,
   ERR_INVALID_ARG_VALUE,
   ERR_INVALID_IP_ADDRESS,
 } = errors.codes;
@@ -131,8 +130,8 @@ class Resolver {
   setLocalAddress(ipv4, ipv6) {
     validateString(ipv4, 'ipv4');
 
-    if (typeof ipv6 !== 'string' && ipv6 !== undefined) {
-      throw new ERR_INVALID_ARG_TYPE('ipv6', ['String', 'undefined'], ipv6);
+    if (ipv6 !== undefined) {
+      validateString(ipv6, 'ipv6');
     }
 
     this._handle.setLocalAddress(ipv4, ipv6);