test: check error and cleanups in test-fs-read-buffer

Use arrow functions and prefer `strictEqual` over `deepStrictEqual` where it works. PR-URL: #10611 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Jan 6, 2017 · eab9563 · eab9563
1 parent 334be0f
commit eab9563
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/test/parallel/test-fs-read-buffer.js b/test/parallel/test-fs-read-buffer.js
@@ -16,6 +16,7 @@ function test(bufferAsync, bufferSync, expected) {
           expected.length,
           0,
           common.mustCall((err, bytesRead) => {
+            assert.ifError(err);
             assert.strictEqual(bytesRead, expected.length);
             assert.deepStrictEqual(bufferAsync, Buffer.from(expected));
           }));

diff --git a/test/parallel/test-fs-write-buffer.js b/test/parallel/test-fs-write-buffer.js
@@ -10,17 +10,17 @@ common.refreshTmpDir();
 // fs.write with all parameters provided:
 {
   const filename = path.join(common.tmpDir, 'write1.txt');
-  fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
+  fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
     assert.ifError(err);
 
-    const cb = common.mustCall(function(err, written) {
+    const cb = common.mustCall((err, written) => {
       assert.ifError(err);
 
       assert.strictEqual(expected.length, written);
       fs.closeSync(fd);
 
       var found = fs.readFileSync(filename, 'utf8');
-      assert.deepStrictEqual(expected.toString(), found);
+      assert.strictEqual(expected.toString(), found);
     });
 
     fs.write(fd, expected, 0, expected.length, null, cb);
@@ -30,17 +30,17 @@ common.refreshTmpDir();
 // fs.write with a buffer, without the length parameter:
 {
   const filename = path.join(common.tmpDir, 'write2.txt');
-  fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
+  fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
     assert.ifError(err);
 
-    const cb = common.mustCall(function(err, written) {
+    const cb = common.mustCall((err, written) => {
       assert.ifError(err);
 
       assert.strictEqual(2, written);
       fs.closeSync(fd);
 
       const found = fs.readFileSync(filename, 'utf8');
-      assert.deepStrictEqual('lo', found);
+      assert.strictEqual('lo', found);
     });
 
     fs.write(fd, Buffer.from('hello'), 3, cb);
@@ -90,17 +90,17 @@ common.refreshTmpDir();
 // fs.write with offset and length passed as undefined followed by the callback:
 {
   const filename = path.join(common.tmpDir, 'write5.txt');
-  fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
+  fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
     assert.ifError(err);
 
-    const cb = common.mustCall(function(err, written) {
+    const cb = common.mustCall((err, written) => {
       assert.ifError(err);
 
       assert.strictEqual(expected.length, written);
       fs.closeSync(fd);
 
       const found = fs.readFileSync(filename, 'utf8');
-      assert.deepStrictEqual(expected.toString(), found);
+      assert.strictEqual(expected.toString(), found);
     });
 
     fs.write(fd, expected, undefined, undefined, cb);
@@ -110,17 +110,17 @@ common.refreshTmpDir();
 // fs.write with a Uint8Array, without the offset and length parameters:
 {
   const filename = path.join(common.tmpDir, 'write6.txt');
-  fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
+  fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
     assert.ifError(err);
 
-    const cb = common.mustCall(function(err, written) {
+    const cb = common.mustCall((err, written) => {
       assert.ifError(err);
 
       assert.strictEqual(expected.length, written);
       fs.closeSync(fd);
 
       const found = fs.readFileSync(filename, 'utf8');
-      assert.deepStrictEqual(expected.toString(), found);
+      assert.strictEqual(expected.toString(), found);
     });
 
     fs.write(fd, Uint8Array.from(expected), cb);