net: don't create unnecessary closure

Don't call `Function#bind()` when a direct method call works just as well and is much cheaper. PR-URL: #12342 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · May 2, 2017 · dcc9e1a · dcc9e1a
1 parent e09202b
commit dcc9e1a
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -836,26 +836,20 @@ function internalConnect(
   var err;
 
   if (localAddress || localPort) {
-    var bind;
+    debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
+          localAddress, localPort, addressType);
 
     if (addressType === 4) {
       localAddress = localAddress || '0.0.0.0';
-      bind = self._handle.bind;
+      err = self._handle.bind(localAddress, localPort);
     } else if (addressType === 6) {
       localAddress = localAddress || '::';
-      bind = self._handle.bind6;
+      err = self._handle.bind6(localAddress, localPort);
     } else {
       self._destroy(new TypeError('Invalid addressType: ' + addressType));
       return;
     }
 
-    debug('binding to localAddress: %s and localPort: %d',
-          localAddress,
-          localPort);
-
-    bind = bind.bind(self._handle);
-    err = bind(localAddress, localPort);
-
     if (err) {
       const ex = exceptionWithHostPort(err, 'bind', localAddress, localPort);
       self._destroy(ex);