net: only defer _final call when connecting

Fixes: #47322 PR-URL: #47385 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
nodejs · May 8, 2023 · c15bafd · c15bafd
1 parent 9398ff1
commit c15bafd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -508,7 +508,7 @@ Socket.prototype._unrefTimer = function _unrefTimer() {
 // sent out to the other side.
 Socket.prototype._final = function(cb) {
   // If still connecting - defer handling `_final` until 'connect' will happen
-  if (this.pending) {
+  if (this.connecting) {
     debug('_final: not yet connected');
     return this.once('connect', () => this._final(cb));
   }

diff --git a/test/parallel/test-net-end-without-connect.js b/test/parallel/test-net-end-without-connect.js
@@ -20,8 +20,11 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+const common = require('../common');
 const net = require('net');
+const assert = require('assert');
 
 const sock = new net.Socket();
-sock.end();  // Should not throw.
+sock.end(common.mustCall(() => {
+  assert.strictEqual(sock.writable, false);
+}));