console: use a plain object for the the error stack

Using a object instead of an Error is sufficient as the Error itself won't be used but only the stack trace that would otherwise be created twice. This improves the overall .trace() performance. PR-URL: #13743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
nodejs · Jun 29, 2017 · bf69891 · bf69891
1 parent d45d3ba
commit bf69891
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/console.js b/lib/console.js
@@ -150,11 +150,10 @@ Console.prototype.timeEnd = function timeEnd(label) {
 
 
 Console.prototype.trace = function trace(...args) {
-  // TODO probably can to do this better with V8's debug object once that is
-  // exposed.
-  var err = new Error();
-  err.name = 'Trace';
-  err.message = util.format.apply(null, args);
+  const err = {
+    name: 'Trace',
+    message: util.format.apply(null, args)
+  };
   Error.captureStackTrace(err, trace);
   this.error(err.stack);
 };