stream: writable don't throw multiple callback error

Align ERR_MULTIPLE_CALLBACK in Writable with the rest of error handling as well as how the error is implemented in Transform.
nodejs · Nov 23, 2019 · b1320d8 · b1320d8
1 parent f171112
commit b1320d8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -467,8 +467,10 @@ function onwrite(stream, er) {
   const sync = state.sync;
   const cb = state.writecb;
 
-  if (typeof cb !== 'function')
-    throw new ERR_MULTIPLE_CALLBACK();
+  if (typeof cb !== 'function') {
+    errorOrDestroy(stream, new ERR_MULTIPLE_CALLBACK());
+    return
+  }
 
   state.writing = false;
   state.writecb = null;

diff --git a/test/parallel/test-stream-writable-callback-twice copy.js b/test/parallel/test-stream-writable-callback-twice copy.js
@@ -0,0 +1,14 @@
+'use strict';
+const common = require('../common');
+const { Writable } = require('stream');
+const stream = new Writable({
+  write(chunk, enc, cb) { cb(); cb(); }
+});
+
+stream.on('error', common.expectsError({
+  type: Error,
+  message: 'Callback called multiple times',
+  code: 'ERR_MULTIPLE_CALLBACK'
+}));
+
+stream.write('foo');