Skip to content

Commit

Permalink
test: silence compiler warning in openssl-binding
Browse files Browse the repository at this point in the history
Currently, this test generated the following compiler warning:
../binding.cc:33:30: warning:
'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations]
  const SSL_METHOD* method = TLSv1_2_server_method();
                             ^
/node/deps/openssl/openssl/include/openssl/ssl.h:1877:1:
note: 'TLSv1_2_server_method' has been explicitly marked deprecated here
DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void))
^
1 warning generated.

This commit adds -Wno-deprecated-declarations to silence this warning
for this test.

PR-URL: #26067
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
  • Loading branch information
danbev authored and rvagg committed Feb 28, 2019
1 parent 497d9d8 commit a920721
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions test/addons/openssl-binding/binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@
'sources': ['binding.cc'],
'include_dirs': ['../../../deps/openssl/openssl/include'],
}],
['OS=="mac"', {
'xcode_settings': {
'OTHER_CFLAGS+': [
'-Wno-deprecated-declarations',
],
},
}, {
'cflags': ['-Wno-deprecated-declarations'],
}],
],
},
]
Expand Down

0 comments on commit a920721

Please sign in to comment.