src: --abort-on-uncaught-exception in NODE_OPTIONS

Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. Backport-PR-URL: #12677 PR-URL: #13932 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 16, 2017 · a76c2ae · a76c2ae
1 parent c98baa4
commit a76c2ae
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -367,6 +367,7 @@ Node options that are allowed are:
 - `--zero-fill-buffers`
 
 V8 options that are allowed are:
+- `--abort-on-uncaught-exception`
 - `--max_old_space_size`
 
 

diff --git a/src/node.cc b/src/node.cc
@@ -3811,6 +3811,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
     "--icu-data-dir",
 
     // V8 options
+    "--abort-on-uncaught-exception",
     "--max_old_space_size",
   };
 

diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -41,7 +41,8 @@ function disallow(opt) {
 
 const printA = require.resolve('../fixtures/printA.js');
 
-expect('-r ' + printA, 'A\nB\n');
+expect(`-r ${printA}`, 'A\nB\n');
+expect('--abort-on-uncaught-exception', 'B\n');
 expect('--no-deprecation', 'B\n');
 expect('--no-warnings', 'B\n');
 expect('--trace-warnings', 'B\n');
@@ -58,7 +59,7 @@ if (common.hasCrypto) {
 }
 expect('--icu-data-dir=_d', 'B\n');
 
-    // V8 options
+// V8 options
 expect('--max_old_space_size=0', 'B\n');
 
 function expect(opt, want) {