http2: store headersSent after stream destroyed

Store headersSent directly on response state after finish event is triggered, so that users can always access it. Fixes: #15226
nodejs · Sep 7, 2017 · a5d6a6f · a5d6a6f
1 parent 4477155
commit a5d6a6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -299,7 +299,7 @@ class Http2ServerResponse extends Stream {
 
   get headersSent() {
     const stream = this[kStream];
-    return stream.headersSent;
+    return stream !== undefined ? stream.headersSent : this[kState].headersSent;
   }
 
   get sendDate() {
@@ -526,6 +526,7 @@ class Http2ServerResponse extends Stream {
     if (code !== undefined)
       state.closedCode = code;
     state.closed = true;
+    state.headersSent = this[kStream].headersSent;
     this.end();
     this[kStream] = undefined;
     this.emit('finish');

diff --git a/test/parallel/test-http2-compat-serverresponse-headers.js b/test/parallel/test-http2-compat-serverresponse-headers.js
@@ -88,6 +88,7 @@ server.listen(0, common.mustCall(function() {
 
     response.on('finish', common.mustCall(function() {
       assert.strictEqual(response.code, h2.constants.NGHTTP2_NO_ERROR);
+      assert.strictEqual(response.headersSent, true);
       server.close();
     }));
     response.end();