[squash] fix bug from targos’ review

nodejs · Mar 27, 2017 · a3decc4 · a3decc4
1 parent 9db1853
commit a3decc4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/v8.js b/lib/v8.js
@@ -140,7 +140,12 @@ class DefaultSerializer extends Serializer {
     if (abView.constructor === Buffer) {
       i = bufferConstructorIndex;
     } else {
-      i = arrayBufferViewTypeToIndex.get(objectToString(abView));
+      const tag = objectToString(abView);
+      i = arrayBufferViewTypeToIndex.get(tag);
+
+      if (i === undefined) {
+        throw this._getDataCloneError(`Unknown host object type: ${tag}`);
+      }
     }
     this.writeUint32(i);
     this.writeUint32(abView.byteLength);

diff --git a/test/parallel/test-v8-serdes.js b/test/parallel/test-v8-serdes.js
@@ -99,6 +99,11 @@ const objects = [
   }, /foobar/);
 }
 
+{
+  assert.throws(() => v8.serialize(process.stdin._handle),
+                /^Error: Unknown host object type: \[object .*\]$/);
+}
+
 {
   const buf = Buffer.from('ff0d6f2203666f6f5e007b01', 'hex');