url: always show password for URL instances

This matches browser behavior. PR-URL: #12420 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · May 1, 2017 · a2d3161 · a2d3161
1 parent 41e052a
commit a2d3161
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -215,8 +215,6 @@ class URL {
       throw new TypeError('Value of `this` is not a URL');
     }
 
-    const ctx = this[context];
-
     if (typeof depth === 'number' && depth < 0)
       return opts.stylize('[Object]', 'special');
 
@@ -230,8 +228,7 @@ class URL {
     obj.origin = this.origin;
     obj.protocol = this.protocol;
     obj.username = this.username;
-    obj.password = (opts.showHidden || ctx.password === '') ?
-                     this.password : '--------';
+    obj.password = this.password;
     obj.host = this.host;
     obj.hostname = this.hostname;
     obj.port = this.port;

diff --git a/test/parallel/test-whatwg-url-inspect.js b/test/parallel/test-whatwg-url-inspect.js
@@ -21,7 +21,7 @@ assert.strictEqual(
   origin: 'https://host.name:8080',
   protocol: 'https:',
   username: 'username',
-  password: '--------',
+  password: 'password',
   host: 'host.name:8080',
   hostname: 'host.name',
   port: '8080',