src: fix what a dispose without checking

If created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called. Backport-PR-URL: #35241 Refs: #31260 Co-authored-by: Anna Henningsen <[email protected]> PR-URL: #30467 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
nodejs · Sep 23, 2020 · a28c990 · a28c990
1 parent 2f8f767
commit a28c990
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/node_v8_platform-inl.h b/src/node_v8_platform-inl.h
@@ -12,6 +12,7 @@
 #include "tracing/node_trace_writer.h"
 #include "tracing/trace_event.h"
 #include "tracing/traced_value.h"
+#include "util.h"
 
 namespace node {
 
@@ -79,8 +80,12 @@ class NodeTraceStateObserver
 };
 
 struct V8Platform {
+  bool initialized_ = false;
+
 #if NODE_USE_V8_PLATFORM
   inline void Initialize(int thread_pool_size) {
+    CHECK(!initialized_);
+    initialized_ = true;
     tracing_agent_ = std::make_unique<tracing::Agent>();
     node::tracing::TraceEventHelper::SetAgent(tracing_agent_.get());
     node::tracing::TracingController* controller =
@@ -99,6 +104,10 @@ struct V8Platform {
   }
 
   inline void Dispose() {
+    if (!initialized_)
+      return;
+    initialized_ = false;
+
     StopTracingAgent();
     platform_->Shutdown();
     delete platform_;