net: remove ADDRCONFIG DNS hint on Windows

On Windows setting ADDRCONFIG causes localhost resolution to fail if there are no network connections. This removes that flag on Windows. Fixes: #17641 PR-URL: #17662 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Feb 11, 2018 · 9ab79e1 · 9ab79e1
1 parent 019c528
commit 9ab79e1
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/net.js b/lib/net.js
@@ -995,7 +995,10 @@ function lookupAndConnect(self, options) {
     hints: options.hints || 0
   };
 
-  if (dnsopts.family !== 4 && dnsopts.family !== 6 && dnsopts.hints === 0) {
+  if (process.platform !== 'win32' &&
+      dnsopts.family !== 4 &&
+      dnsopts.family !== 6 &&
+      dnsopts.hints === 0) {
     dnsopts.hints = dns.ADDRCONFIG;
   }