module: silence ModuleJob unhandled rejection warnings

This could otherwise print unhandled rejection warnings if the process does not exit immediately inside an earlier `.catch()` handler. PR-URL: #25769 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 30, 2019 · 94ebf3f · 94ebf3f
1 parent 8919169
commit 94ebf3f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/internal/modules/esm/module_job.js b/lib/internal/modules/esm/module_job.js
@@ -6,6 +6,8 @@ const { decorateErrorStack } = require('internal/util');
 const assert = require('assert');
 const resolvedPromise = SafePromise.resolve();
 
+function noop() {}
+
 /* A ModuleJob tracks the loading of a single Module, and the ModuleJobs of
  * its dependencies, over time. */
 class ModuleJob {
@@ -41,6 +43,9 @@ class ModuleJob {
     };
     // Promise for the list of all dependencyJobs.
     this.linked = link();
+    // This promise is awaited later anyway, so silence
+    // 'unhandled rejection' warnings.
+    this.linked.catch(noop);
 
     // instantiated == deep dependency jobs wrappers instantiated,
     // module wrapper instantiated