Apply suggestions from code review

Co-authored-by: Antoine du Hamel <[email protected]>
nodejs · Nov 27, 2024 · 8e29103 · 8e29103
1 parent e3b9537
commit 8e29103
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -3779,6 +3779,9 @@ changes:
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/55753
     description: Runtime deprecation.
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55892
+    description: Documentation-only.
 -->
 
 Type: Runtime

diff --git a/lib/fs.js b/lib/fs.js
@@ -286,7 +286,10 @@ function existsSync(path) {
   try {
     path = getValidatedPath(path);
   } catch {
-    deprecate(() => {}, 'Passing invalid argument types to fs.existsSync is deprecated', 'DEP0187');
+    if (!deprecationWarningEmitted) {
+      process.emitWarning('Passing invalid argument types to fs.existsSync is deprecated', 'DeprecationWarning', 'DEP0187');
+      deprecationWarningEmitted = true;
+    }
     return false;
   }