buffer: properly apply dst offset and src length on fast path

Refs: #54311 (comment) PR-URL: #54391 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
nodejs · Aug 21, 2024 · 8ba53ae · 8ba53ae
1 parent 0b16af1
commit 8ba53ae
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -1479,11 +1479,12 @@ uint32_t FastWriteString(Local<Value> receiver,
   CHECK(offset <= dst.length());
   CHECK(dst.length() - offset <= std::numeric_limits<uint32_t>::max());
 
-  max_length = std::min<uint32_t>(dst.length() - offset, max_length);
+  const auto size = std::min(
+      {static_cast<uint32_t>(dst.length() - offset), max_length, src.length});
 
-  memcpy(dst_data, src.data, max_length);
+  memcpy(dst_data + offset, src.data, size);
 
-  return max_length;
+  return size;
 }
 
 static v8::CFunction fast_write_string(v8::CFunction::Make(FastWriteString));