test: refactor the code in test-util-debug.js

* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed unwanted console log

PR-URL: #10531
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>

test/sequential/test-util-debug.js

@@ -17,44 +17,43 @@ function parent() {
 }
 
 function test(environ, shouldWrite) {
-  var expectErr = '';
+  let expectErr = '';
   if (shouldWrite) {
     expectErr = 'TUD %PID%: this { is: \'a\' } /debugging/\n' +
                 'TUD %PID%: number=1234 string=asdf obj={"foo":"bar"}\n';
   }
-  var expectOut = 'ok\n';
+  const expectOut = 'ok\n';
 
   const spawn = require('child_process').spawn;
-  var child = spawn(process.execPath, [__filename, 'child'], {
+  const child = spawn(process.execPath, [__filename, 'child'], {
     env: Object.assign(process.env, { NODE_DEBUG: environ })
   });
 
   expectErr = expectErr.split('%PID%').join(child.pid);
 
-  var err = '';
+  let err = '';
   child.stderr.setEncoding('utf8');
-  child.stderr.on('data', function(c) {
+  child.stderr.on('data', (c) => {
     err += c;
   });
 
-  var out = '';
+  let out = '';
   child.stdout.setEncoding('utf8');
-  child.stdout.on('data', function(c) {
+  child.stdout.on('data', (c) => {
     out += c;
   });
 
-  child.on('close', common.mustCall(function(c) {
+  child.on('close', common.mustCall((c) => {
     assert(!c);
-    assert.equal(err, expectErr);
-    assert.equal(out, expectOut);
-    console.log('ok %j %j', environ, shouldWrite);
+    assert.strictEqual(err, expectErr);
+    assert.strictEqual(out, expectOut);
   }));
 }
 
 
 function child() {
   const util = require('util');
-  var debug = util.debuglog('tud');
+  const debug = util.debuglog('tud');
   debug('this', { is: 'a' }, /debugging/);
   debug('number=%d string=%s obj=%j', 1234, 'asdf', { foo: 'bar' });
   console.log('ok');