dgram: fix unhandled exception aborting a closed udp socket

Fixes: #46750 PR-URL: #46770 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 5, 2023 · 8646b06 · 8646b06
1 parent 63a62ed
commit 8646b06
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -139,7 +139,7 @@ function Socket(type, listener) {
     const { signal } = options;
     validateAbortSignal(signal, 'options.signal');
     const onAborted = () => {
-      this.close();
+      if (this[kStateSymbol].handle) this.close();
     };
     if (signal.aborted) {
       onAborted();

diff --git a/test/parallel/test-dgram-abort-closed.js b/test/parallel/test-dgram-abort-closed.js
@@ -0,0 +1,10 @@
+'use strict';
+require('../common');
+const dgram = require('dgram');
+
+const controller = new AbortController();
+const socket = dgram.createSocket({ type: 'udp4', signal: controller.signal });
+
+socket.close();
+
+controller.abort();