Skip to content

Commit

Permalink
test: enhance test-common.js
Browse files Browse the repository at this point in the history
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()

PR-URL: #11433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
Trott authored and jasnell committed Feb 19, 2017
1 parent bc44d2c commit 7b76f82
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion test/parallel/test-common.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,25 @@
const common = require('../common');
const assert = require('assert');

common.globalCheck = false;

// test for leaked global detection
global.gc = 42; // Not a valid global unless --expose_gc is set.
assert.deepStrictEqual(common.leakedGlobals(), ['gc']);
delete global.gc;


// common.mustCall() tests
assert.throws(function() {
common.mustCall(function() {}, 'foo');
}, /^TypeError: Invalid expected value: foo$/);

assert.throws(function() {
common.mustCall(function() {}, /foo/);
}, /^TypeError: Invalid expected value: \/foo\/$/);


// common.fail() tests
assert.throws(
() => { common.fail('fhqwhgads'); },
/^AssertionError: fhqwhgads$/
);

0 comments on commit 7b76f82

Please sign in to comment.