node: improve performance of process.hrtime()

Move argument validation out of C++ and into JS. Improves performance by about 15-20%. PR-URL: #4484 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 30, 2015 · 78fd435 · 78fd435
1 parent bfa925f
commit 78fd435
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 18 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -2138,18 +2138,8 @@ void Kill(const FunctionCallbackInfo<Value>& args) {
 // and nanoseconds, to avoid any integer overflow possibility.
 // Pass in an Array from a previous hrtime() call to instead get a time diff.
 void Hrtime(const FunctionCallbackInfo<Value>& args) {
-  Environment* env = Environment::GetCurrent(args);
-
   uint64_t t = uv_hrtime();
 
-  if (!args[1]->IsUndefined()) {
-    if (!args[1]->IsArray()) {
-      return env->ThrowTypeError(
-          "process.hrtime() only accepts an Array tuple");
-    }
-    args.GetReturnValue().Set(true);
-  }
-
   Local<ArrayBuffer> ab = args[0].As<Uint32Array>()->Buffer();
   uint32_t* fields = static_cast<uint32_t*>(ab->GetContents().Data());
 

diff --git a/src/node.js b/src/node.js
@@ -192,15 +192,23 @@
     }
 
     process.hrtime = function hrtime(ar) {
-      const ret = [0, 0];
-      if (_hrtime(hrValues, ar)) {
-        ret[0] = (hrValues[0] * 0x100000000 + hrValues[1]) - ar[0];
-        ret[1] = hrValues[2] - ar[1];
-      } else {
-        ret[0] = hrValues[0] * 0x100000000 + hrValues[1];
-        ret[1] = hrValues[2];
+      _hrtime(hrValues);
+
+      if (typeof ar !== 'undefined') {
+        if (Array.isArray(ar)) {
+          return [
+            (hrValues[0] * 0x100000000 + hrValues[1]) - ar[0],
+            hrValues[2] - ar[1]
+          ];
+        }
+
+        throw new TypeError('process.hrtime() only accepts an Array tuple');
       }
-      return ret;
+
+      return [
+        hrValues[0] * 0x100000000 + hrValues[1],
+        hrValues[2]
+      ];
     };
   };