test,stream: fix pipeline test so it runs well on Windows in older nodes

This test is ported automatically in readable-stream, and it fails there on Windows and older Node.js versions because of some bad interactions between the code and the event loop on Windows. See: nodejs/readable-stream#353 PR-URL: #22456 Reviewed-By: Mathias Buus <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Sep 3, 2018 · 7794d4e · 7794d4e
1 parent e254130
commit 7794d4e
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -165,8 +165,13 @@ const { promisify } = require('util');
 
 {
   const server = http.createServer((req, res) => {
+    let sent = false;
     const rs = new Readable({
       read() {
+        if (sent) {
+          return;
+        }
+        sent = true;
         rs.push('hello');
       },
       destroy: common.mustCall((err, cb) => {
@@ -195,8 +200,12 @@ const { promisify } = require('util');
 
 {
   const server = http.createServer((req, res) => {
+    let sent = 0;
     const rs = new Readable({
       read() {
+        if (sent++ > 10) {
+          return;
+        }
         rs.push('hello');
       },
       destroy: common.mustCall((err, cb) => {
@@ -242,8 +251,12 @@ const { promisify } = require('util');
       port: server.address().port
     });
 
+    let sent = 0;
     const rs = new Readable({
       read() {
+        if (sent++ > 10) {
+          return;
+        }
         rs.push('hello');
       }
     });