Skip to content

Commit

Permalink
build: avoid compiling with VS v17.12
Browse files Browse the repository at this point in the history
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
StefanStojanovic authored and aduh95 committed Nov 26, 2024
1 parent ce53f16 commit 7133c04
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,19 @@ goto exit
@rem Visual Studio v17.10 has a bug that causes the build to fail.
@rem Check if the version is v17.10 and exit if it is.
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
if %errorlevel% neq 1 (
if %errorlevel% neq 1 (
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
goto exit
)
@rem Same applies to v17.12 for MSVC.
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
if %errorlevel% neq 1 (
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
if not defined clang_cl (
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
goto exit
)
)

@rem check if the clang-cl build is requested
if not defined clang_cl goto clang-skip
Expand Down

0 comments on commit 7133c04

Please sign in to comment.