Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation broken on Windows with VS 17.12 #3963

Open
StefanStojanovic opened this issue Nov 18, 2024 · 1 comment
Open

Compilation broken on Windows with VS 17.12 #3963

StefanStojanovic opened this issue Nov 18, 2024 · 1 comment
Assignees
@StefanStojanovic

Comments

@StefanStojanovic
Copy link
Contributor

VS 2022 v17.12 (released Nov 12) cannot compile Node.js with MSVC. I'm working on making a simple reproduceable example to open an issue in developercommunity.visualstudio.com.

cc @nodejs/platform-windows

Refs: #3739
@StefanStojanovic StefanStojanovic self-assigned this Nov 18, 2024
@StefanStojanovic
Copy link
Contributor Author

Here is the developer community issue.

This was referenced Nov 20, 2024
Open
Open
StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Nov 20, 2024
@StefanStojanovic
build: avoid compiling with VS v17.12
0585ef1 
Refs: nodejs/build#3963
This was referenced Nov 20, 2024
Merged
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Nov 26, 2024
@StefanStojanovic
build: avoid compiling with VS v17.12
542f252 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this issue Nov 26, 2024
@StefanStojanovic @aduh95
build: avoid compiling with VS v17.12
7133c04 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanStojanovic StefanStojanovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StefanStojanovic