fs: remove redundant code in readableWebStream()

Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: #49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Nov 26, 2023 · 69b7f91 · 69b7f91
1 parent ddebd29
commit 69b7f91
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 16 deletions.
diff --git a/doc/api/fs.md b/doc/api/fs.md
@@ -444,7 +444,7 @@ Reads data from the file and stores that in the given buffer.
 If the file is not modified concurrently, the end-of-file is reached when the
 number of bytes read is zero.
 
-#### `filehandle.readableWebStream(options)`
+#### `filehandle.readableWebStream([options])`
 
 <!-- YAML
 added: v17.0.0

diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -276,17 +276,8 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {
         this[kHandle],
         undefined,
         { ondone: () => this[kUnref]() });
-
-      const {
-        readableStreamCancel,
-      } = require('internal/webstreams/readablestream');
-      this[kRef]();
-      this.once('close', () => {
-        readableStreamCancel(readable);
-      });
     } else {
       const {
-        readableStreamCancel,
         ReadableStream,
       } = require('internal/webstreams/readablestream');
 
@@ -313,14 +304,16 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {
           ondone();
         },
       });
-
-      this[kRef]();
-
-      this.once('close', () => {
-        readableStreamCancel(readable);
-      });
     }
 
+    const {
+      readableStreamCancel,
+    } = require('internal/webstreams/readablestream');
+    this[kRef]();
+    this.once('close', () => {
+      readableStreamCancel(readable);
+    });
+
     return readable;
   }