buffer: avoid materializing ArrayBuffer for creation

Do not create an `ArrayBuffer` if the engine’s settings avoid it and we don’t need it. PR-URL: #26301 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 1, 2019 · 5e4aa28 · 5e4aa28
1 parent 9b4eec0
commit 5e4aa28
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -106,21 +106,17 @@ let poolSize, poolOffset, allocPool;
 const zeroFill = bindingZeroFill || [0];
 
 function createUnsafeBuffer(size) {
-  return new FastBuffer(createUnsafeArrayBuffer(size));
-}
-
-function createUnsafeArrayBuffer(size) {
   zeroFill[0] = 0;
   try {
-    return new ArrayBuffer(size);
+    return new FastBuffer(size);
   } finally {
     zeroFill[0] = 1;
   }
 }
 
 function createPool() {
   poolSize = Buffer.poolSize;
-  allocPool = createUnsafeArrayBuffer(poolSize);
+  allocPool = createUnsafeBuffer(poolSize).buffer;
   poolOffset = 0;
 }
 createPool();