src: avoid copying string in fs_permission

PR-URL: #47746 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
nodejs · May 2, 2023 · 5b50322 · 5b50322
1 parent 5e99598
commit 5b50322
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -89,7 +89,7 @@ void FSPermission::Apply(const std::string& allow, PermissionScope scope) {
   }
 }
 
-void FSPermission::GrantAccess(PermissionScope perm, std::string res) {
+void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
   const std::string path = WildcardIfDir(res);
   if (perm == PermissionScope::kFileSystemRead) {
     granted_in_fs_.Insert(path);

diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h
@@ -130,7 +130,7 @@ class FSPermission final : public PermissionBase {
   };
 
  private:
-  void GrantAccess(PermissionScope scope, std::string param);
+  void GrantAccess(PermissionScope scope, const std::string& param);
   void RestrictAccess(PermissionScope scope,
                       const std::vector<std::string>& params);
   // fs granted on startup