test: improve assertions in pummel/test-timers

* Timers should not fire early. Check for that. * Allow the wiggle-room to increase on subsequent iterations of intervals. PR-URL: #35216 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
nodejs · Sep 22, 2020 · 5a6bdd0 · 5a6bdd0
1 parent 1018e52
commit 5a6bdd0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test/pummel/test-timers.js b/test/pummel/test-timers.js
@@ -36,7 +36,7 @@ const WINDOW = 200; // Why does this need to be so big?
     assert.ok(diff > 0);
     console.error(`diff: ${diff}`);
 
-    assert.strictEqual(1000 - WINDOW < diff && diff < 1000 + WINDOW, true);
+    assert.ok(1000 <= diff && diff < 1000 + WINDOW);
   }), 1000);
 }
 
@@ -61,7 +61,7 @@ const WINDOW = 200; // Why does this need to be so big?
 
     const t = interval_count * 1000;
 
-    assert.ok(t - WINDOW < diff && diff < t + WINDOW, `t: ${t}`);
+    assert.ok(t <= diff && diff < t + (WINDOW * interval_count));
 
     assert.ok(interval_count <= 3, `interval_count: ${interval_count}`);
     if (interval_count === 3)