lib: update TODO comments

This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33361 Reviewed-By: Anto Aravinth <[email protected]>
nodejs · Jun 18, 2020 · 59d435e · 59d435e
1 parent 4e74f05
commit 59d435e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -855,6 +855,8 @@ Interface.prototype._ttyWrite = function(s, key) {
   if (key.ctrl && key.shift) {
     /* Control and shift pressed */
     switch (key.name) {
+      // TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
+      // identical to <ctrl>-h. It should have a unique escape sequence.
       case 'backspace':
         this._deleteLineLeft();
         break;
@@ -952,8 +954,10 @@ Interface.prototype._ttyWrite = function(s, key) {
         }
         break;
 
-      // TODO(BridgeAR): This seems broken?
       case 'w': // Delete backwards to a word boundary
+      // TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
+      // identical to <ctrl>-h. It should have a unique escape sequence.
+      // Falls through
       case 'backspace':
         this._deleteWordLeft();
         break;

diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -957,8 +957,6 @@ assertDeepAndStrictEqual(obj1, obj2);
 
 // Check proxies.
 {
-  // TODO(BridgeAR): Check if it would not be better to detect proxies instead
-  // of just using the proxy value.
   const arrProxy = new Proxy([1, 2], {});
   assert.deepStrictEqual(arrProxy, [1, 2]);
   const tmp = util.inspect.defaultOptions;