stream: return readable stream on promisified pipeline

nodejs · Oct 29, 2021 · 56ec619 · 56ec619
1 parent c0a7020
commit 56ec619
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/lib/stream/promises.js b/lib/stream/promises.js
@@ -23,11 +23,15 @@ function pipeline(...streams) {
       signal = options.signal;
     }
 
-    pl(streams, (err, value) => {
+    const stream = pl(streams, (err, value) => {
       if (err) {
         reject(err);
-      } else {
+      } else if (value !== undefined) {
         resolve(value);
+      } else if (stream.readable) {
+        resolve(stream);
+      } else {
+        resolve();
       }
     }, { signal });
   });

diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -1406,3 +1406,29 @@ const tsp = require('timers/promises');
   }));
   ac.abort();
 }
+
+{
+  const pipelinePromise = promisify(pipeline);
+
+  async function run() {
+    const read = new Readable({
+      read() {}
+    });
+
+    const duplex = new PassThrough();
+
+    read.push('data');
+    read.push(null);
+
+    const stream = await pipelinePromise(read, duplex);
+
+    let ret = ''
+    for await (const x of stream) {
+      ret += x;
+    }
+
+    assert.strictEqual(ret, 'data');
+  }
+
+  run();
+}