stream: emit 'pause' on unpipe

unpipe should use pause() instead of mutating state.flowing directly so that pausing side effects such as emitting 'pause' are properly performed. Fixes: #32470 PR-URL: #32476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Mar 26, 2020 · 56da8df · 56da8df
1 parent deab08b
commit 56da8df
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -818,7 +818,7 @@ Readable.prototype.unpipe = function(dest) {
     // remove all.
     var dests = state.pipes;
     state.pipes = [];
-    state.flowing = false;
+    this.pause();
 
     for (const dest of dests)
       dest.emit('unpipe', this, { hasUnpiped: false });
@@ -832,7 +832,7 @@ Readable.prototype.unpipe = function(dest) {
 
   state.pipes.splice(index, 1);
   if (state.pipes.length === 0)
-    state.flowing = false;
+    this.pause();
 
   dest.emit('unpipe', this, unpipeInfo);
 

diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js
@@ -84,3 +84,13 @@ assert.strictEqual(source._readableState.pipes.length, 0);
   checkDestCleanup(dest2);
   source.unpipe();
 }
+
+{
+  const src = Readable({ read: () => {} });
+  const dst = Writable({ write: () => {} });
+  src.pipe(dst);
+  src.on('resume', common.mustCall(() => {
+    src.on('pause', common.mustCall());
+    src.unpipe(dst);
+  }));
+}