src: add file name to 'Module did not self-register' error

PR-URL: #30125 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
nodejs · Nov 19, 2019 · 4f43418 · 4f43418
1 parent 7cecac6
commit 4f43418
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/src/node_binding.cc b/src/node_binding.cc
@@ -484,7 +484,12 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
         mp = dlib->GetSavedModuleFromGlobalHandleMap();
         if (mp == nullptr || mp->nm_context_register_func == nullptr) {
           dlib->Close();
-          env->ThrowError("Module did not self-register.");
+          char errmsg[1024];
+          snprintf(errmsg,
+                   sizeof(errmsg),
+                   "Module did not self-register: '%s'.",
+                   *filename);
+          env->ThrowError(errmsg);
           return false;
         }
       }

diff --git a/test/addons/dlopen-ping-pong/test-worker.js b/test/addons/dlopen-ping-pong/test-worker.js
@@ -16,5 +16,6 @@ require(bindingPath);
 new Worker(`require(${JSON.stringify(bindingPath)})`, { eval: true })
   .on('error', common.mustCall((err) => {
     assert.strictEqual(err.constructor, Error);
-    assert.strictEqual(err.message, 'Module did not self-register.');
+    assert.strictEqual(err.message,
+                       `Module did not self-register: '${bindingPath}'.`);
   }));
diff --git a/test/addons/dlopen-ping-pong/test.js b/test/addons/dlopen-ping-pong/test.js
@@ -19,5 +19,5 @@ assert.strictEqual(module.exports.ping(), 'pong');
 // Check that after the addon is loaded with
 // process.dlopen() a require() call fails.
 console.log('require:', `./build/${common.buildType}/binding`);
-const re = /^Error: Module did not self-register\.$/;
+const re = /^Error: Module did not self-register: '.*[\\/]binding\.node'\.$/;
 assert.throws(() => require(`./build/${common.buildType}/binding`), re);
diff --git a/test/addons/not-a-binding/test.js b/test/addons/not-a-binding/test.js
@@ -2,5 +2,5 @@
 const common = require('../../common');
 const assert = require('assert');
 
-const re = /^Error: Module did not self-register\.$/;
+const re = /^Error: Module did not self-register: '.*[\\/]binding\.node'\.$/;
 assert.throws(() => require(`./build/${common.buildType}/binding`), re);