-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR-URL: #45982 Fixes: #45699 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
- Loading branch information
1 parent
41f5a29
commit 4df1fcc
Showing
7 changed files
with
132 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
test/parallel/test-http-request-join-authorization-headers.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const http = require('http'); | ||
|
||
{ | ||
const server = http.createServer({ | ||
requireHostHeader: false, | ||
joinDuplicateHeaders: true | ||
}, common.mustCall((req, res) => { | ||
assert.strictEqual(req.headers.authorization, '1, 2'); | ||
assert.strictEqual(req.headers.cookie, 'foo; bar'); | ||
res.writeHead(200, ['authorization', '3', 'authorization', '4', 'cookie', 'foo', 'cookie', 'bar']); | ||
res.end(); | ||
})); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
http.get({ | ||
port: server.address().port, | ||
headers: ['authorization', '1', 'authorization', '2', 'cookie', 'foo', 'cookie', 'bar'], | ||
joinDuplicateHeaders: true | ||
}, (res) => { | ||
assert.strictEqual(res.statusCode, 200); | ||
assert.strictEqual(res.headers.authorization, '3, 4'); | ||
assert.strictEqual(res.headers.cookie, 'foo; bar'); | ||
res.resume().on('end', common.mustCall(() => { | ||
server.close(); | ||
})); | ||
}); | ||
})); | ||
} | ||
|
||
{ | ||
// Server joinDuplicateHeaders false | ||
const server = http.createServer({ | ||
requireHostHeader: false, | ||
joinDuplicateHeaders: false | ||
}, common.mustCall((req, res) => { | ||
assert.strictEqual(req.headers.authorization, '1'); // non joined value | ||
res.writeHead(200, ['authorization', '3', 'authorization', '4']); | ||
res.end(); | ||
})); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
http.get({ | ||
port: server.address().port, | ||
headers: ['authorization', '1', 'authorization', '2'], | ||
joinDuplicateHeaders: true | ||
}, (res) => { | ||
assert.strictEqual(res.statusCode, 200); | ||
assert.strictEqual(res.headers.authorization, '3, 4'); | ||
res.resume().on('end', common.mustCall(() => { | ||
server.close(); | ||
})); | ||
}); | ||
})); | ||
} | ||
|
||
{ | ||
// Client joinDuplicateHeaders false | ||
const server = http.createServer({ | ||
requireHostHeader: false, | ||
joinDuplicateHeaders: true | ||
}, common.mustCall((req, res) => { | ||
assert.strictEqual(req.headers.authorization, '1, 2'); | ||
res.writeHead(200, ['authorization', '3', 'authorization', '4']); | ||
res.end(); | ||
})); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
http.get({ | ||
port: server.address().port, | ||
headers: ['authorization', '1', 'authorization', '2'], | ||
joinDuplicateHeaders: false | ||
}, (res) => { | ||
assert.strictEqual(res.statusCode, 200); | ||
assert.strictEqual(res.headers.authorization, '3'); // non joined value | ||
res.resume().on('end', common.mustCall(() => { | ||
server.close(); | ||
})); | ||
}); | ||
})); | ||
} |