Skip to content

Commit

Permalink
tls: reduce TLS 'close' event listener warnings
Browse files Browse the repository at this point in the history
Without this, some heavy usage of TLS sockets can result in
MaxListenersExceededWarning firing, from the 'this.on('close', ...)'
line here.

These appear to come from reinitializeHandle, which calls _wrapHandle
repeatedly on the same socket instance.
  • Loading branch information
pimterry committed Oct 11, 2023
1 parent 78a1570 commit 43c4a9e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion lib/_tls_wrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,12 @@ TLSSocket.prototype._wrapHandle = function(wrap, handle, wrapHasActiveWriteFromP
this[kRes] = res;
defineHandleReading(this, handle);

this.on('close', onSocketCloseDestroySSL);
// Guard against adding multiple listeners, as this method may be called
// repeatedly on the same socket by reinitializeHandle
if (this.listenerCount('close', onSocketCloseDestroySSL) === 0) {
this.on('close', onSocketCloseDestroySSL);
}

if (wrap) {
wrap.on('close', () => this.destroy());
}
Expand Down

0 comments on commit 43c4a9e

Please sign in to comment.