test: fix flaky test-net-write-after-close

Replace 250ms timer with event-based logic to make test robust. PR-URL: #14361 Fixes: #13597 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 21, 2017 · 43bd47c · 43bd47c
1 parent 27343cc
commit 43bd47c
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/test/parallel/test-net-write-after-close.js b/test/parallel/test-net-write-after-close.js
@@ -21,24 +21,31 @@
 
 'use strict';
 const common = require('../common');
+
 const net = require('net');
 
+let serverSocket;
+
 const server = net.createServer(common.mustCall(function(socket) {
+  serverSocket = socket;
+
   socket.resume();
 
   socket.on('error', common.mustCall(function(error) {
-    console.error('got error, closing server', error);
+    console.error('received error as expected, closing server', error);
     server.close();
   }));
-
-  setTimeout(common.mustCall(function() {
-    console.error('about to try to write');
-    socket.write('test', common.mustCall());
-  }), 250);
 }));
 
 server.listen(0, function() {
   const client = net.connect(this.address().port, function() {
+    // cliend.end() will close both the readable and writable side
+    // of the duplex because allowHalfOpen defaults to false.
+    // Then 'end' will be emitted when it receives a FIN packet from
+    // the other side.
+    client.on('end', common.mustCall(() => {
+      serverSocket.write('test', common.mustCall());
+    }));
     client.end();
   });
 });