report: widen scope of #ifndef

This commit moves a #ifndef _WIN32 to contain the entire if statement that inspects file descriptors. Prior to this commit, the #ifndef was inside the if, making it essentially dead code on Windows. PR-URL: #25960 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Feb 8, 2019 · 3f40031 · 3f40031
1 parent 8494a61
commit 3f40031
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/node_report_utils.cc b/src/node_report_utils.cc
@@ -163,12 +163,12 @@ void WalkHandle(uv_handle_t* h, void* arg) {
          << ", recv buffer size: " << recv_size;
   }
 
+#ifndef _WIN32
   if (h->type == UV_TCP || h->type == UV_NAMED_PIPE || h->type == UV_TTY ||
       h->type == UV_UDP || h->type == UV_POLL) {
     uv_os_fd_t fd_v;
     int rc = uv_fileno(h, &fd_v);
-    // uv_os_fd_t is an int on Unix and HANDLE on Windows.
-#ifndef _WIN32
+
     if (rc == 0) {
       switch (fd_v) {
         case 0:
@@ -185,8 +185,8 @@ void WalkHandle(uv_handle_t* h, void* arg) {
           break;
       }
     }
-#endif
   }
+#endif
 
   if (h->type == UV_TCP || h->type == UV_NAMED_PIPE || h->type == UV_TTY) {
     data << ", write queue size: " << handle->stream.write_queue_size;