events: remove return value on addEventListener

The `addEventListener()` should not return a value. Signed-off-by: James M Snell <[email protected]> PR-URL: #37696 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Mar 16, 2021 · 3acba1d · 3acba1d
1 parent efd14a9
commit 3acba1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -329,7 +329,7 @@ class EventTarget {
 
     if (signal) {
       if (signal.aborted) {
-        return false;
+        return;
       }
       // TODO(benjamingr) make this weak somehow? ideally the signal would
       // not prevent the event target from GC.

diff --git a/test/parallel/test-eventtarget-whatwg-signal.js b/test/parallel/test-eventtarget-whatwg-signal.js
@@ -25,7 +25,11 @@ const {
   controller.abort();
   et.dispatchEvent(new Event('test'));
   strictEqual(count, 2, 'Aborting on the controller removes the listener');
-  et.addEventListener('test', handler, { signal: controller.signal });
+  // See: https://github.com/nodejs/node/pull/37696 , adding an event listener
+  // should always return undefined.
+  strictEqual(
+    et.addEventListener('test', handler, { signal: controller.signal }),
+    undefined);
   et.dispatchEvent(new Event('test'));
   strictEqual(count, 2, 'Passing an aborted signal never adds the handler');
 }