build: don't build icu with -fno-rtti

ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
nodejs · Nov 18, 2016 · 3919edb · 3919edb
1 parent a3a184d
commit 3919edb
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp
@@ -69,6 +69,7 @@
           [ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
             'cflags': [ '-Wno-deprecated-declarations' ],
             'cflags_cc': [ '-frtti' ],
+            'cflags_cc!': [ '-fno-rtti' ],
           }],
           [ 'OS == "mac" or OS == "ios"', {
             'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },