fs: fix promisified fs.readdir withFileTypes

PR-URL: #22832 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Sep 20, 2018 · 24a35f9 · 24a35f9
1 parent 08e427a
commit 24a35f9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -299,7 +299,8 @@ async function readdir(path, options) {
   path = getPathFromURL(path);
   validatePath(path);
   const result = await binding.readdir(pathModule.toNamespacedPath(path),
-                                       options.encoding, !!options.withTypes,
+                                       options.encoding,
+                                       !!options.withFileTypes,
                                        kUsePromises);
   return options.withFileTypes ?
     getDirectoryEntriesPromise(path, result) :

diff --git a/test/parallel/test-fs-readdir-types.js b/test/parallel/test-fs-readdir-types.js
@@ -57,6 +57,14 @@ fs.readdir(readdirDir, {
   assertDirents(dirents);
 }));
 
+// Check the promisified version
+assert.doesNotReject(async () => {
+  const dirents = await fs.promises.readdir(readdirDir, {
+    withFileTypes: true
+  });
+  assertDirents(dirents);
+});
+
 // Check for correct types when the binding returns unknowns
 const UNKNOWN = constants.UV_DIRENT_UNKNOWN;
 const oldReaddir = binding.readdir;