test: remove common.PORT from test-cluster-basic

Use of `common.PORT` in `parallel` tests is not completely safe (because the same port can be previously assigned to another test running in parallel if that test uses port `0` to get an arbitrary available port). Remove `common.PORT` from test-cluster-basic. PR-URL: #12377 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · May 15, 2017 · 23c55d6 · 23c55d6
1 parent 1370c5a
commit 23c55d6
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/test/parallel/test-cluster-basic.js b/test/parallel/test-cluster-basic.js
@@ -14,10 +14,7 @@ function forEach(obj, fn) {
 
 
 if (cluster.isWorker) {
-  const http = require('http');
-  http.Server(function() {
-
-  }).listen(common.PORT, '127.0.0.1');
+  require('http').Server(common.noop).listen(0, '127.0.0.1');
 } else if (cluster.isMaster) {
 
   const checks = {
@@ -109,11 +106,15 @@ if (cluster.isWorker) {
 
         case 'listening':
           assert.strictEqual(arguments.length, 1);
-          const expect = { address: '127.0.0.1',
-                           port: common.PORT,
-                           addressType: 4,
-                           fd: undefined };
-          assert.deepStrictEqual(arguments[0], expect);
+          assert.strictEqual(Object.keys(arguments[0]).length, 4);
+          assert.strictEqual(arguments[0].address, '127.0.0.1');
+          assert.strictEqual(arguments[0].addressType, 4);
+          assert(arguments[0].hasOwnProperty('fd'));
+          assert.strictEqual(arguments[0].fd, undefined);
+          const port = arguments[0].port;
+          assert(Number.isInteger(port));
+          assert(port >= 1);
+          assert(port <= 65535);
           break;
 
         default: