src: use smart pointer in AsyncWrap::WeakCallback

PR-URL: #19168 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Mar 8, 2018 · 1e3dd8b · 1e3dd8b
1 parent ebfed17
commit 1e3dd8b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/async_wrap.cc b/src/async_wrap.cc
@@ -415,14 +415,14 @@ void AsyncWrap::WeakCallback(const v8::WeakCallbackInfo<DestroyParam>& info) {
   HandleScope scope(info.GetIsolate());
 
   Environment* env = Environment::GetCurrent(info.GetIsolate());
-  DestroyParam* p = info.GetParameter();
+  std::unique_ptr<DestroyParam> p{info.GetParameter()};
   Local<Object> prop_bag = PersistentToLocal(info.GetIsolate(), p->propBag);
 
   Local<Value> val = prop_bag->Get(env->destroyed_string());
   if (val->IsFalse()) {
     AsyncWrap::EmitDestroy(env, p->asyncId);
   }
-  delete p;
+  // unique_ptr goes out of scope here and pointer is deleted.
 }